Add hook to force committing state to disk #280
Draft
+51
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsahee
reviewed
Jan 23, 2024
core/blockchain.go
Outdated
| bc.numberOfBlocksToSkipStateSaving = bc.cacheConfig.MaxNumberOfBlocksToSkipStateSaving | ||
| bc.amountOfGasInBlocksToSkipStateSaving = bc.cacheConfig.MaxAmountOfGasToSkipStateSaving | ||
| return bc.triedb.Commit(root, false) | ||
| } |
There was a problem hiding this comment.
I want the storing-from-force to happen together with storing here:
if bc.gcproc > flushInterval && prevEntry != nil && !archiveNode
So the hook should check gcproc, and if it returns yes gcproc should also be updated.
Hook should probably also get archiveNode (or it can get that info directly)
need to make sure we don't skip over the block in partial-archive and in the for !bc.triegc.Empty() { loop
There was a problem hiding this comment.
not sure it's the best solution, but my current thought is that if the hook is null we use a function that replicates the current behavior for hook (tests bc.gcproc > flushInterval)
This reverts commit 1ac9c79.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.