Diagnostic mode handle SIGTERM #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambchr
reviewed
Sep 30, 2024
There was a problem hiding this comment.
nice, looks good in general, I noticed a couple of issues when trying this out on a test pod. Let me know if you think this is due to an error with the test pod I used:
apiVersion: v1
kind: Pod
metadata:
name: clamb-test
spec:
containers:
- name: clamb
image: offchainlabs/nitro-node:v3.0.3-3ecd01e
command: ["/bin/sh"]
args:
- -c
- |
#!/usr/bin/env bash
set -e pipefail
trap 'exit 0' TERM
sleep infinity &
wait $!
# I used this to check that the signal handling was working
terminationGracePeriodSeconds: 10
| - -c | ||
| - | | ||
| #!/usr/bin/env bash | ||
| set -eo pipefail |
There was a problem hiding this comment.
I got the following error when running this on a test pod /bin/sh: 2: set: Illegal option -o pipefail
Suggested change
| set -eo pipefail | |
| set -e pipefail |
| #!/usr/bin/env bash | ||
| set -eo pipefail | ||
|
|
||
| trap 'exit 0' SIGTERM |
There was a problem hiding this comment.
I got the following error when running this on a test pod trap: SIGTERM: bad trap seems like some shells expect the signal without the SIG part
Suggested change
| trap 'exit 0' SIGTERM | |
| trap 'exit 0' TERM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.