Merge All Current Cargo Stylus Subcommands Into Main Package #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gligneul
reviewed
Aug 27, 2024
rory-ocl
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have a weird
cargo-stylus-check,cargo-stylus-replay, and a few other binaries that are then invoked using raw command utilities inside ofcargo-stylus, which is the main binary. This approach gives us the flexibility of supporting custom extensions to cargo stylus. However, all the current subcommands are arguably critical and should be part of the principal cargo stylus binary. This refactors the repo to do that, while maintaining the flexibility of supporting custom extensions.Merge #78, #79, #80, #81 first
Closes #83
Closes #88