Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Fixes for UX #29

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Minor Fixes for UX #29

merged 3 commits into from
Feb 1, 2024

Conversation

rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Feb 1, 2024 •
edited
Loading

Closes #23 and closes #24.

  • This PR adds a flag that makes it possible to skip contract size checks to avoid failing cargo stylus altogether when in development
  • Prints estimate gas costs in a more user-friendly manner
  • Prints insufficient allowance errors in a more user-friendly manner

joshuacolvin0
joshuacolvin0 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauljordan rauljordan merged commit a2ac0dd into main Feb 1, 2024
8 checks passed
@rauljordan rauljordan deleted the minor-improvements-jan-2024 branch February 1, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rauljordan @joshuacolvin0