Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect Context Cancel in time.After Invocations #717

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Respect Context Cancel in time.After Invocations #717

merged 1 commit into from
Dec 23, 2024

Conversation

rauljordan
Copy link
Collaborator

Not using context cancel in a select block leads to issues in preventing graceful shutdown

ganeshvanahalli
ganeshvanahalli approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauljordan rauljordan merged commit fcb5b8c into main Dec 23, 2024
5 checks passed
@rauljordan rauljordan deleted the respect-context-cancel branch December 23, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshvanahalli ganeshvanahalli ganeshvanahalli approved these changes

@eljobe eljobe Awaiting requested review from eljobe

@terencechain terencechain Awaiting requested review from terencechain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rauljordan @ganeshvanahalli