fix check

assertions/poster.go

@@ -164,7 +164,8 @@ func (m *Manager) PostAssertionBasedOnParent(
 	// contracts check for overflow assertion => assertion.afterState.globalState.u64Vals[0] < assertion.beforeStateData.configData.nextInboxPosition)
 	// then should check if we need to wait for the minimum number of blocks between assertions and a minimum time since parent assertion creation.
 	// Overflow ones are not subject to this check onchain.
-	if newState.GlobalState.Batch >= batchCount {
+	isOverflowAssertion := newState.MachineStatus != protocol.MachineStatusErrored && newState.GlobalState.PosInBatch < batchCount
+	if !isOverflowAssertion {
 		if err = m.waitToPostIfNeeded(ctx, parentCreationInfo); err != nil {
 			return none, err
 		}

assertions/poster_test.go

@@ -55,17 +55,13 @@ func TestPostAssertion(t *testing.T) {
 	stateManager, err := statemanager.NewForSimpleMachine(t, stateManagerOpts...)
 	require.NoError(t, err)
 
-	// Set MinimumGapToBlockCreationTime as 1 second to verify that a new assertion is only posted after 1 sec has passed
-	// from parent assertion creation. This will make the test run for ~19 seconds as the parent assertion time is
-	// ~18 seconds in the future
 	assertionManager, err := assertions.NewManager(
 		aliceChain,
 		stateManager,
 		"alice",
 		types.DefensiveMode,
 		assertions.WithPollingInterval(time.Millisecond*200),
 		assertions.WithAverageBlockCreationTime(time.Second),
-		assertions.WithMinimumGapToParentAssertion(time.Second),
 	)
 	require.NoError(t, err)