Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow scw to change destination chain #2139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −3
Open

feat: allow scw to change destination chain #2139

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebf0bb3
feat: allow scw to change destination chain
fionnachan Dec 13, 2024
010610f
Merge branch 'master' into allow-destination-selection-scw
fionnachan Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/arb-token-bridge-ui/src/components/TransferPanel/AdvancedSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ export const AdvancedSettings = () => {
isDepositMode
} = useNetworksRelationship(networks)
const { address } = useAccount()
const { isEOA, isSmartContractWallet } = useAccountType()
const {
isEOA,
isSmartContractWallet,
isLoading: isLoadingAccountType
} = useAccountType()

const [inputLocked, setInputLocked] = useState(true)
const [warning, setWarning] = useState<string | null>(null)
Expand Down Expand Up @@ -165,7 +169,7 @@ export const AdvancedSettings = () => {
})
}, [debouncedDestinationAddress, setQueryParams])

if (!isEOA && !isSmartContractWallet) {
if (!isEOA && !isSmartContractWallet && !isLoadingAccountType) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to check for isLoadingAccountType here otherwise after switching destination chain, the destination address box won't show up

image

return null
}

Expand Down
5 changes: 4 additions & 1 deletion packages/arb-token-bridge-ui/src/components/common/NetworkSelectionContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,10 @@ export function NetworkButton({

const hasOneOrLessChain = chains.length <= 1

const disabled = hasOneOrLessChain || isSmartContractWallet || isLoading
const disabled =
hasOneOrLessChain ||
(isSmartContractWallet && type === 'source') ||
isLoading

const buttonStyle = {
backgroundColor: getBridgeUiConfigForChain(selectedChainId).color
Expand Down
Loading