feat: add exponential backoff for withdrawals queries #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
spsjvc
force-pushed
the
feat-exponential-backoff
branch
from
34ace79 to
a68c4f9
Compare
spsjvc
changed the title
spsjvc
commented
Dec 10, 2024
| @@ -22,7 +22,7 @@ export function fetchETHWithdrawalsFromEventLogs({ | |||
| l2Provider: Provider | |||
| }) { | |||
| if (typeof receiver === 'undefined') { | |||
| return [] | |||
There was a problem hiding this comment.
otherwise the type would be never[]
fionnachan
reviewed
Dec 12, 2024
| } | ||
|
|
||
| export function backOff<T>(request: () => Promise<T>): Promise<T> { | ||
| return _backOff(request, backoffOptions) |
There was a problem hiding this comment.
do we want to turn on full jitter?
https://aws.amazon.com/blogs/architecture/exponential-backoff-and-jitter/
i think we do?
fionnachan
approved these changes
Dec 12, 2024
brtkx
approved these changes
Dec 12, 2024
dewanshparashar
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Steps to test