refactor: Remove useArbTokenBridge from store 3/3 #2090
+160
−432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrstph-dvx
changed the title
chrstph-dvx
force-pushed
the
fs-1001/replace-useAppState-calls
branch
from
f1be4ee to
3e54561
Compare
chrstph-dvx
force-pushed
the
fs-1001/add-usecallbacks
branch
from
c72b3a9 to
5789015
Compare
fionnachan
reviewed
Nov 21, 2024
Comment on lines
-77
to
-95
| useEffect(() => { | ||
| if (!nativeCurrency.isCustom) { | ||
| return | ||
| } | ||
|
|
||
| const selectedTokenAddress = selectedToken?.address.toLowerCase() | ||
| const selectedTokenL2Address = selectedToken?.l2Address?.toLowerCase() | ||
| // This handles a super weird edge case where, for example: | ||
| // | ||
| // Your setup is: from Arbitrum One to Mainnet, and you have $ARB selected as the token you want to bridge over. | ||
| // You then switch your destination network to a network that has $ARB as its native currency. | ||
| // For this network, $ARB can only be bridged as the native currency, and not as a standard ERC-20, which is why we have to reset the selected token. | ||
| if ( | ||
| selectedTokenAddress === nativeCurrency.address || | ||
| selectedTokenL2Address === nativeCurrency.address | ||
| ) { | ||
| actions.app.setSelectedToken(null) | ||
| } | ||
| }, [selectedToken, nativeCurrency]) |
There was a problem hiding this comment.
nice, tested with APE token for Ape chain and it works well after deletion
Comment on lines
+86
to
+93
| if (selectedToken) { | ||
| updateTokenData(selectedToken.address) | ||
| } |
There was a problem hiding this comment.
missing updateUSDCBalances() from BalanceUpdater and so USDC doesn't get updated, e.g. native USDC on Arb Sepolia
There was a problem hiding this comment.
Changed back here aa3d8fc (#2090)
chrstph-dvx
force-pushed
the
fs-1001/add-usecallbacks
branch
from
5789015 to
94da1e5
Compare
chrstph-dvx
force-pushed
the
fs-1001/replace-useAppState-calls
branch
from
3e54561 to
f5b2dad
Compare
chrstph-dvx
force-pushed
the
fs-1001/replace-useAppState-calls
branch
from
f5b2dad to
bdd3de5
Compare
chrstph-dvx
force-pushed
the
fs-1001/add-usecallbacks
branch
from
a376a1a to
718b487
Compare
chrstph-dvx
force-pushed
the
fs-1001/replace-useAppState-calls
branch
from
aa3d8fc to
29ed1d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace useAppState calls with useArbTokenBridge
Steps to test