refactor: Remove useArbTokenBridge from store 2/3 #2089
+368
−309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrstph-dvx
changed the title
chrstph-dvx
force-pushed
the
fs-1001/add-usecallbacks
branch
from
c72b3a9 to
5789015
Compare
chrstph-dvx
force-pushed
the
fs-1001/add-useBridgeTokensStore
branch
from
cb9121a to
747c8f4
Compare
fionnachan
reviewed
Nov 21, 2024
| @@ -417,130 +451,157 @@ export const useArbTokenBridge = ( | |||
| ] | |||
| ) | |||
There was a problem hiding this comment.
there's a missing dependency here, i know you didn't change it but can you add destinationAddress to the dep array please?
There was a problem hiding this comment.
Fixed in a376a1a (#2089)
chrstph-dvx
force-pushed
the
fs-1001/add-useBridgeTokensStore
branch
from
b09b794 to
31b866b
Compare
chrstph-dvx
force-pushed
the
fs-1001/add-usecallbacks
branch
from
5789015 to
94da1e5
Compare
chrstph-dvx
force-pushed
the
fs-1001/add-useBridgeTokensStore
branch
from
31b866b to
54e32b1
Compare
chrstph-dvx
force-pushed
the
fs-1001/add-usecallbacks
branch
from
a376a1a to
718b487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wrap methods with useCallbacks in useArbTokenBridge
Steps to test