feat: add sanity checks in bridge sdk transfer function #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brtkx
reviewed
Oct 3, 2024
packages/arb-token-bridge-ui/src/token-bridge-sdk/Erc20WithdrawalStarter.ts
Outdated
Show resolved
Hide resolved
|
|
||
| if (signerChainId !== sourceChainId) { | ||
| throw new Error( | ||
| `Signer is on chain ${signerChainId} but should be on chain ${sourceChainId}.` |
There was a problem hiding this comment.
Should we also have some actionable here - eg. "Please check your connection / Please try again after refreshing/reconnecting your wallet."
| @@ -59,12 +64,25 @@ export class EthWithdrawalStarter extends BridgeTransferStarter { | |||
| throw 'Native currency withdrawals to a custom destination address are not supported yet.' | |||
| } | |||
|
|
|||
| await validateSignerChainId({ | |||
There was a problem hiding this comment.
Everywhere - We should also add a check for addressIsSmartContract along with this.
- We can abstract
validateSignerChainId + addressIsSmartContract = validateTransfer (or something like that)as 1 function which takes in the toAddress+signer as input and does all the checks within it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FS-858