fix: fetch balances when wallet address is valid #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into dest-address-performance
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brtkx
changed the title
spsjvc
approved these changes
Jul 22, 2024
douglance
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with
useBalanceswhere passing any destination address would retrigger fetching, even if the address is not valid. This also caused flakiness in ERC20 deposit and withdrawal e2e.Testing
Before:
On prod you should see
useBalanceretrigger in the network tab with each character typed in the custom destination address.After:
useBalanceupdates only when the custom destination address is complete and valid.