-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move token state into query params #1770
Open
brtkx
wants to merge
86
commits into
master
Choose a base branch
from
token-query-params
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
09dcda7
sanitize query params server-side
spsjvc 0c96f54
forgot to export
spsjvc c64cb4f
fix
spsjvc 0cbadce
Merge branch 'master' into feat-sanitize-query-params-server-side
chrstph-dvx 7ee3ba6
Fix server-side sanitizing of network query param for orbit chains
chrstph-dvx b78af5c
Omit server sanitization if both chains are missing
chrstph-dvx 6d347e6
Keep previous params
chrstph-dvx eed4192
Properly encode amount param
chrstph-dvx 8996822
Merge branch 'master' into feat-sanitize-query-params-server-side
chrstph-dvx ce0837c
Merge branch 'master' into feat-sanitize-query-params-server-side
fionnachan 1388a70
Merge branch 'master' into feat-sanitize-query-params-server-side
chrstph-dvx 3ac1ae9
Merge branch 'master' into feat-sanitize-query-params-server-side
chrstph-dvx fb6e2d7
simplify getDestinationChainIds
chrstph-dvx c672d43
Merge branch 'master' into feat-sanitize-query-params-server-side
chrstph-dvx 4708a2a
Merge branch 'master' into feat-sanitize-query-params-server-side
chrstph-dvx 934418f
token-query-params
brtkx 941a8a9
fix
brtkx 44b8608
fixes
brtkx 0e05993
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 6047fc4
unused var
brtkx b53430e
fix
brtkx 3252775
try
brtkx 12d6a41
fix e2e
brtkx 038c544
e2e fixes and clean up
brtkx 059a969
clean ups and fixes e2e
brtkx 976617c
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 5e16815
fixes
brtkx 62d7668
fixes
brtkx 0e26cb0
fixes
brtkx 83fde15
Merge branch 'feat-sanitize-query-params-server-side' of github.com:O…
brtkx 707cd12
video
brtkx 3c1379d
video
brtkx 76965c3
revert
brtkx 6dcdf2a
try
brtkx 4b60ae8
reduce rerendering
brtkx ea5e0bc
fixes
brtkx 921927f
log
brtkx 6fbd77f
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 552f7f6
optimization
brtkx 12fcae3
try fix tests
brtkx 93529c9
Revert "try fix tests"
brtkx 9acd027
fix
brtkx f06e4b2
fix
brtkx 9eb3400
remove videos
brtkx 0f24a23
Merge branch 'master' into token-query-params
brtkx 1910fd4
Merge branch 'master' into token-query-params
brtkx eb2e8eb
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx e2c0bac
merge changes
brtkx 23f17b9
merge
brtkx be37c03
clean up
brtkx b5dd720
fix usdce bals
brtkx 0508911
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx afa23a3
fix
brtkx b8b35c5
address hook comments
brtkx 128ed01
Merge branch 'master' into token-query-params
brtkx 1524536
fixes
brtkx 9108a5c
Merge branch 'token-query-params' of github.com:OffchainLabs/arbitrum…
brtkx a01384c
Merge branch 'master' into token-query-params
brtkx 99bca1b
updates
brtkx d35e69d
Merge github.com:OffchainLabs/arbitrum-token-bridge into token-query-…
brtkx 5944ec2
merge
brtkx 2bd4938
fix
brtkx c70da10
fix
brtkx 2fc92cf
token loaders
brtkx 9247fd5
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 4ffe912
loader color
brtkx c01e2e5
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 904afb9
updates
brtkx b9b567e
fix
brtkx 04ea158
fix tests
brtkx c70c2ee
Merge branch 'master' into token-query-params
fionnachan be331dc
Merge branch 'master' into token-query-params
fionnachan 012ae4a
fix
brtkx 01af184
Merge branch 'token-query-params' of github.com:OffchainLabs/arbitrum…
brtkx be8c31e
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx d7d4dec
fix
brtkx 1c408bf
fix
brtkx 38f650c
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx b230818
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx a326ce0
fix
brtkx f6207cb
Merge branch 'master' into token-query-params
chrstph-dvx e6d6d4c
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 402aed4
fix build
brtkx 18fba1a
Merge branch 'master' into token-query-params
brtkx 410d974
Merge branch 'master' into token-query-params
brtkx 37b7305
Merge branch 'master' into token-query-params
fionnachan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 2 additions & 4 deletions
6
packages/arb-token-bridge-ui/src/components/TransferPanel/NativeCurrencyPrice.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This caused a lot of rerenders because
useSelectedToken
usestokenBridge
data under the hood. This block of code is not needed anyway because we set token tonull
when networks change