feat: don't require wallet connection #1452
+321
−313
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| import { useEffect } from 'react' | ||
| import { useAccount } from 'wagmi' | ||
| import * as Sentry from '@sentry/react' | ||
|
|
||
| import { useNetworks } from '../../hooks/useNetworks' | ||
| import { useNetworksRelationship } from '../../hooks/useNetworksRelationship' | ||
| import { ProviderName, trackEvent } from '../../util/AnalyticsUtils' | ||
| import { rpcURLs } from '../../util/networks' | ||
|
|
||
| // connector names: https://github.com/wagmi-dev/wagmi/blob/b17c07443e407a695dfe9beced2148923b159315/docs/pages/core/connectors/_meta.en-US.json#L4 | ||
| function getWalletName(connectorName: string): ProviderName { | ||
| switch (connectorName) { | ||
| case 'MetaMask': | ||
| case 'Coinbase Wallet': | ||
| case 'Trust Wallet': | ||
| case 'Safe': | ||
| case 'Injected': | ||
| case 'Ledger': | ||
| return connectorName | ||
|
|
||
| case 'WalletConnectLegacy': | ||
| case 'WalletConnect': | ||
| return 'WalletConnect' | ||
|
|
||
| default: | ||
| return 'Other' | ||
| } | ||
| } | ||
|
|
||
| /** given our RPC url, sanitize it before logging to Sentry, to only pass the url and not the keys */ | ||
| function getBaseUrl(url: string | undefined): string | null { | ||
| if (typeof url === 'undefined') { | ||
| return null | ||
| } | ||
|
|
||
| try { | ||
| const urlObject = new URL(url) | ||
| return `${urlObject.protocol}//${urlObject.hostname}` | ||
| } catch { | ||
| // if invalid url passed | ||
| return null | ||
| } | ||
| } | ||
|
|
||
| export function useSyncConnectedChainToAnalytics() { | ||
| const { isConnected, connector } = useAccount() | ||
|
|
||
| const [networks] = useNetworks() | ||
| const { parentChain, childChain } = useNetworksRelationship(networks) | ||
|
|
||
| useEffect(() => { | ||
| if (isConnected && connector) { | ||
| const walletName = getWalletName(connector.name) | ||
| trackEvent('Connect Wallet Click', { walletName }) | ||
|
There was a problem hiding this comment. I know it's coming exactly from the previous file, but wouldn't this fire on every-refresh? Ideally we want it to fire only when we connect to UI using the connect wallet button. There was a problem hiding this comment.
|
||
|
|
||
| // set a custom tag in sentry to filter issues by connected wallet.name | ||
| Sentry.setTag('wallet.name', walletName) | ||
| } | ||
| }, [isConnected, connector]) | ||
|
|
||
| useEffect(() => { | ||
| Sentry.setTag('network.parent_chain_id', parentChain.id) | ||
| Sentry.setTag('network.child_chain_id', childChain.id) | ||
|
|
||
| const parentChainRpcUrl = getBaseUrl(rpcURLs[parentChain.id]) | ||
| const childChainRpcUrl = getBaseUrl(rpcURLs[childChain.id]) | ||
|
|
||
| if (parentChainRpcUrl) { | ||
| Sentry.setTag('network.parent_chain_rpc_url', parentChainRpcUrl) | ||
| } | ||
|
|
||
| if (childChainRpcUrl) { | ||
| Sentry.setTag('network.child_chain_rpc_url', childChainRpcUrl) | ||
| } | ||
| }, [childChain.id, parentChain.id]) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { useState, useEffect } from 'react' | ||
| import { useNetwork } from 'wagmi' | ||
|
|
||
| import { useArbQueryParams } from '../../hooks/useArbQueryParams' | ||
| import { sanitizeQueryParams } from '../../hooks/useNetworks' | ||
|
|
||
| export function useSyncConnectedChainToQueryParams() { | ||
| const [shouldSync, setShouldSync] = useState(false) | ||
| const [didSync, setDidSync] = useState(false) | ||
|
|
||
| const { chain } = useNetwork() | ||
| const [{ sourceChain, destinationChain }, setQueryParams] = | ||
| useArbQueryParams() | ||
|
|
||
| useEffect(() => { | ||
| if (shouldSync) { | ||
| return | ||
| } | ||
|
|
||
| // Only sync connected chain to query params if the query params were not initially provided | ||
| if ( | ||
| typeof sourceChain === 'undefined' && | ||
| typeof destinationChain === 'undefined' | ||
| ) { | ||
| setShouldSync(true) | ||
| } | ||
| }, [shouldSync, sourceChain, destinationChain]) | ||
|
|
||
| useEffect(() => { | ||
| // When the chain is connected and we should sync, and we haven't synced yet, sync the connected chain to the query params | ||
| if (chain && shouldSync && !didSync) { | ||
| const { | ||
| sourceChainId: sourceChain, | ||
| destinationChainId: destinationChain | ||
| } = sanitizeQueryParams({ | ||
| sourceChainId: chain.id, | ||
| destinationChainId: undefined | ||
| }) | ||
|
|
||
| setQueryParams({ sourceChain, destinationChain }) | ||
| setDidSync(true) | ||
| } | ||
| }, [chain, shouldSync, didSync, setQueryParams]) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted these into
useSyncConnectedChainToAnalytics