Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract status mapping methods #1311

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Conversation

brtkx
Copy link
Contributor

@brtkx brtkx commented Nov 27, 2023

@cla-bot cla-bot bot added the cla-signed label Nov 27, 2023
Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arbitrum-token-bridge ✅ Ready (Inspect) Visit Preview Nov 28, 2023 5:14pm

spsjvc
spsjvc previously approved these changes Nov 28, 2023
)

return finalTransactions
return ethDepositsFromSubgraph
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is just a misnomer and this actually includes token deposits, too?

Copy link
Member

@fionnachan fionnachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

@spsjvc spsjvc enabled auto-merge (squash) November 28, 2023 17:13
@spsjvc spsjvc merged commit f516a80 into master Nov 28, 2023
24 checks passed
@spsjvc spsjvc deleted the extract-status-mapping branch November 28, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants