feat: keep networks state in query params #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: spsjvc <[email protected]>
Co-authored-by: spsjvc <[email protected]>
…onship-to-our-codebase
…onship-to-our-codebase
…onship-to-our-codebase
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrstph-dvx
changed the title
chrstph-dvx
changed the title
…enetworks-and-usenetworksrelationship
spsjvc
reviewed
Jan 16, 2024
packages/arb-token-bridge-ui/src/components/TransferPanel/TransferPanelMain.tsx
Outdated
Show resolved
Hide resolved
| @@ -669,6 +642,12 @@ export function TransferPanelMain({ | |||
| const maxAmount = nativeCurrencyBalanceFloat - estimatedTotalGasFees * 1.4 | |||
| // make sure it's always a positive number | |||
| // if it's negative, set it to user's balance to show insufficient for gas error | |||
| console.log( | |||
| }) | ||
| if (!didUpdateUrlWithSanitizedValues) { | ||
| // On the first render, update query params with the sanitized values | ||
| console.log('initial set query params in useNetworks') |
spsjvc
changed the title
…sferPanelMain.tsx Co-authored-by: spsjvc <[email protected]>
spsjvc
approved these changes
Jan 16, 2024
fionnachan
approved these changes
Jan 16, 2024
spsjvc
deleted the
1298-replace-usenetworksandsigners-with-usenetworks-and-usenetworksrelationship
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #1295
Steps to test