-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INT-121] feat: update node config for nitro v2.2.x #45
Conversation
In the block: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New stuff looks good, prior comment was on some existing config that should be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested with 2 chains (on with DAC, one without) on top of Arbitrum Sepolia with v2.2.4:
This PR updates
prepareNodeConfig
so it uses the latest node configuration format as of nitro v2.2.2 (including 2.2.3 and 2.2.4)Most changes are just relocating the configuration since the structure has changed since 2.1.x. However, one more configuration option has been added:
node.delayed-sequencer.use-merge-finality: false,
. This configuration makes the delayed sequencer to not wait for full finality on the parent chain before sequencing messages coming from the parent chain, making it more comfortable to work with cross-chain messages.As an example, the orbit-setup-script always waits for the cross-chain messages to be executed on the orbit chain. Without this parameter, the orbit-setup-script takes around 40 minutes to fully execute, although it's likely to timeout while waiting for the createTokenBridge retryable execution.
NOTE: Coordination is needed to merge this PR along with the change in the Orbit setup-script and the update of the Orbit SDK package in the Orbit deployment UI.