Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INT-121] feat: update node config for nitro v2.2.x #45

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

TucksonDev
Copy link
Contributor

@TucksonDev TucksonDev commented Feb 5, 2024

This PR updates prepareNodeConfig so it uses the latest node configuration format as of nitro v2.2.2 (including 2.2.3 and 2.2.4)

Most changes are just relocating the configuration since the structure has changed since 2.1.x. However, one more configuration option has been added: node.delayed-sequencer.use-merge-finality: false,. This configuration makes the delayed sequencer to not wait for full finality on the parent chain before sequencing messages coming from the parent chain, making it more comfortable to work with cross-chain messages.

As an example, the orbit-setup-script always waits for the cross-chain messages to be executed on the orbit chain. Without this parameter, the orbit-setup-script takes around 40 minutes to fully execute, although it's likely to timeout while waiting for the createTokenBridge retryable execution.

NOTE: Coordination is needed to merge this PR along with the change in the Orbit setup-script and the update of the Orbit SDK package in the Orbit deployment UI.

@TucksonDev TucksonDev changed the title chore: update nodeConfig for nitro 2.2.3 chore: update nodeConfig for nitro 2.2.x Feb 7, 2024
@Tristan-Wilson
Copy link
Member

In the block:
if (chainConfig.arbitrum.DataAvailabilityCommittee) {
rpc and rest aggregators should not be the same port. RPC is 9876 and REST is 9877
https://docs.arbitrum.io/node-running/how-tos/data-availability-committee/deploy-a-das#step-3-deploy-the-das

Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New stuff looks good, prior comment was on some existing config that should be fixed.

@TucksonDev TucksonDev marked this pull request as ready for review February 8, 2024 12:50
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spsjvc spsjvc changed the title chore: update nodeConfig for nitro 2.2.x feat: update node config for nitro v2.2.x Feb 13, 2024
@spsjvc spsjvc self-requested a review February 13, 2024 10:04
Copy link
Member

@spsjvc spsjvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spsjvc spsjvc merged commit 3dac3f0 into main Feb 13, 2024
6 checks passed
@spsjvc spsjvc deleted the chore-update-node-config-for-nitro-2.2.3 branch February 13, 2024 10:05
@hkalodner hkalodner changed the title feat: update node config for nitro v2.2.x [INT-121] feat: update node config for nitro v2.2.x Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants