fix: allow custom parent chain RPC (and fix bug) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TucksonDev
changed the title
TucksonDev
changed the title
Jason-W123
approved these changes
Jan 26, 2024
TucksonDev
merged commit 179c6d8
into
feat-add-verification-scripts
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the public RPC for Sepolia or Ethereum mainnet, the query to search for events might take too long and the request might timeout.
This is a temporary patch that allows a custom RPC to be specified which will perform these searches faster.
The solution to the problem, however, is to somehow restrict the range of blocks to search events on. This patch will allow clients to continue using the verification script in the short term.
This PR also fixes one bug that breaks the script when getting admins of contracts that have leading 0s in them.