feat: Configure Fast Withdrawals using Safe #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InoMurko
changed the title
InoMurko
force-pushed
the
inomurko/multisig-fw-public
branch
from
94615df to
4cd0a06
Compare
TucksonDev
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Thanks @InoMurko !
I've left some initial comments about the general structure, let me know what you think 🙏
InoMurko
force-pushed
the
inomurko/multisig-fw-public
branch
from
0b27950 to
9821184
Compare
spsjvc
reviewed
Oct 31, 2024
InoMurko
force-pushed
the
inomurko/multisig-fw-public
branch
from
5234764 to
ef76209
Compare
Co-authored-by: spsjvc <[email protected]>
Co-authored-by: spsjvc <[email protected]>
InoMurko
force-pushed
the
inomurko/multisig-fw-public
branch
from
ef76209 to
ebbf155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollups tend to have ownership transferred to a Safe multi-signature account. These 4 scripts propose transactions to the Safe if there's at least one EOA account in the Safe ownership.
I had to change two types in
src/createSafePrepareTransactionRequest.tsandsrc/setAnyTrustFastConfirmerPrepareTransactionRequest.tsbecause they were too restrictive on the type of the account passed in.The first one is
creating the Safetransaction. The owner here is the Safe that owns the Rollup. Hence there's no Private Key. The second one is setting thenew safeas the Fast Confirmer, this is also sent from the Rollup Safe.