Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Add how to verify l2 state on l1 page #1067
base: master
Are you sure you want to change the base?
[Draft] Add how to verify l2 state on l1 page #1067
Changes from 4 commits
34054c5
0771b49
921fbc0
699b874
60714d9
e1ce475
88a8195
db4e210
f5ae697
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some duplication between this content and The Rollup Chain in Inside Arbitrum Nitro.
This is also explaining how things work, not how you, dear developer, can do something.
One option would be to:
It could also be useful to explicitly state - when and why would a developer need to complete these steps? When do they need to care about manually verifying state? Is this a "just in case you don't trust the underlying protocol" thing? I imagine some developers may expect this to be baked into the protocol and effectively abstracted away from the happy path, so getting more precise about the "user story" above can help us align on a more precisely targeted content objective.
As a developer who ______, I want to learn how to ________ when/because ________
I'll pause this review until we're aligned on the above nits 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have optimism's repo refer here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... is an example available that does not point to a competitor's assets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's open source so I think we're happy to use it