-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting arbitrary options #10
base: master
Are you sure you want to change the base?
Conversation
It looks like some option disappeared, am I right? Can you describe if (or not) this is backwards compatible. Maybe using some examples? |
This supports arbitrary options, but this is not backwards compatible in the sense that in some cases, one needs to rewrite their variables if they want to achieve the same effect. So for example,
Becomes:
The idea is that options that would appear in an iface section (as in below "iface eth0 inet dhcp") are named directly after the option. This allows to support arbitrary options that were not possible before, and that I needed. For example, I am using this on my server now (note the "request_prefix" option)
It all boils down to the lines 13-17 in templates/etc/network/interfaces.d/device.j2. |
Add post-up and pre-down inline hook scripts
This would solve #9.
Let me know if you are ok with this PR (in that case, integrate it). If you do not like it, I would just fork the role for my own use.