Templated duply scripts #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows one to configure 'tpre' and 'tpost' values which allow for dynamic script creation. No templates are provided since they're likely to be closely tied to the related inventory. Implementation for question in First draft for Oefenweb#24
Mention the tpre and tpost options exist and that if pre/post are set the t* versions are ignored.
Because there are several common extensions for templates the '.j2' requirement is removed from tpre and tpost.
|
I have just tested again and seen the expected behaviour so hopefully this is OK to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templated pre and post run scripts
Allows one to configure 'tpre' and 'tpost' values which allow for dynamic script creation.
No templates are provided since they're likely to be closely tied to the related inventory.
I've lightly tested this to confirm it works with templates, is properly optional, and those sorts of things.
I'm not sure I got the logic for "remove obsolete pre scripts" (or post scripts) correct so more testing is required there.
Closes #24