Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a TODO about gke-cloud-auth-plugin #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mjhilton
Copy link

@mjhilton mjhilton commented Nov 30, 2022

This PR is a no-op, it just adds a TODO comment for the future, if we bump kubectl.

[sc-6271]

Add a comment to the Ubuntu Dockerfile to ensure that future maintainers will add the `gke-cloud-auth-plugin` if needed
Add a comment to the Ubuntu Dockerfile to ensure that future maintainers will add the `gke-cloud-auth-plugin` if needed
@mjhilton
Copy link
Author

I do not intend for us to tag or release a new version of WorkerTools based on this PR, it can just sit in master.
We'll wait for other functional changes before unnecessarily creating a release.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we don't push a new tag then the release pipeline won't be triggered, so it is safe to just add this comment 👍

@shortcut-integration
Copy link

@harrisonmeister
Copy link

Just an FYI - I found adding the gke-gcloud-auth-plugin simple enough on ubuntu, but not so for windows.

See OctopusDeployLabs/k8s-workertools#6 for more details. If there is a more elegant way, I'd love to know it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants