Test Exception Contracts for Tentacle Client #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwoctopusdeploy
force-pushed
the
sast/test-exception-contracts
branch
3 times, most recently
from
6b77e55 to
e138114
Compare
| new[] | ||
| { | ||
| "Script execution was cancelled", | ||
| "A task was canceled." // Cancellation during StartScript while connecting throws the wrong error |
There was a problem hiding this comment.
This gets removed in the future 🥳
nathanwoctopusdeploy
force-pushed
the
sast/test-exception-contracts
branch
3 times, most recently
from
f810686 to
4424472
Compare
...opus.Tentacle.Tests.Integration/Support/ExceptionContractAssertionBuilderExtensionMethods.cs
Outdated
Show resolved
Hide resolved
...opus.Tentacle.Tests.Integration/Support/ExceptionContractAssertionBuilderExtensionMethods.cs
Show resolved
Hide resolved
...opus.Tentacle.Tests.Integration/Support/ExceptionContractAssertionBuilderExtensionMethods.cs
Outdated
Show resolved
Hide resolved
source/Octopus.Tentacle.Tests.Integration/ClientScriptExecutionRetriesTimeout.cs
Show resolved
Hide resolved
nathanwoctopusdeploy
force-pushed
the
sast/test-exception-contracts
branch
3 times, most recently
from
05be2eb to
ea8c002
Compare
nathanwoctopusdeploy
force-pushed
the
sast/test-exception-contracts
branch
from
ea8c002 to
9b19f36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
How to review this PR
Quality ✔️
Pre-requisites