Support overriding configuration directories in K8s Container #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #66137: Explore using NFS server for shared storage with tentacle + jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The Kubernetes Tentacle needs to be able to configure the directory path for the home + application directories so they can be specified to be on a NFS/volume mount
Results
The container now takes the
TentacleHomeandTentacleApplicationsenvironment variables and uses them inconfigure-tentacle.shif they are set to override the default values.We also now explicitly set the
homedirectory in thecreate-instancecommand (for clarity).Also some minor bash cleanups:
! -zis the same as-nShortcut story: [sc-66137]
How to review this PR
Quality ✔️
Pre-requisites