Mount helm login secret in arbitrary location to prevent conflict with default helm behaviour #1049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The agent upgrade credentials secret is mounted directly into /root/.config/helm/registry/config.json.
This makes the container directory READ ONLY.
Thus - if a job attempts to manually perform a "helm registry login" - it fails, as the config.json file is also readonly (regardless of if the secret is defined or not).
This change mounts the secret in an arbitrary location (/root/agent_upgrade/config.json), such that default helm operations continue to operate as expected.
For tasks to use the mounted secret, they are expected to export "HELM_REGISTRY_CONFIG=/root/agent_upgrade/config.json" prior to making a helm call.
Results
Fixes https://github.com/OctopusDeploy/Issues/issues/... (optional public issue)
Fixes https://github.com/OctopusDeploy/ResearchAndDevelopment/issues/... (optional private issue)
See How we use GitHub Issues (including this flowchart
How to review this PR
Quality ✔️
Pre-requisites