Mount agent-upgrade credentials default location in filesystem #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APErebus
approved these changes
Nov 26, 2024
Comment on lines
84
to
100
| new() | ||
| { | ||
| Name = "agent-upgrade", | ||
| Secret = new V1SecretVolumeSource | ||
| { | ||
| SecretName = "agent-upgrade-secret", | ||
| Items = new List<V1KeyToPath>() | ||
| { | ||
| new() | ||
| { | ||
| Key = ".dockerconfigjson", | ||
| Path = "config.json" | ||
| } | ||
| }, | ||
| Optional = true, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Can we define this as a method in the base KubernetesScriptPodCreator, so we don't have it defined twice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
To avoid rate-limiting when polling docker for agent versions/charts - helm must be provided with credentials via the
~/.config/helm/registry/config.jsonfile (though will fallback to docker config/env).This change is responsible for mapping the secret in the helm chart, into the filesystem of the script-pod.
It is optional, such that if the secret does not exist, and empty directory is mounted instead.
The change was required to be made to both raw, and normal script pods (though there should be a nicer way of doing this to avoid string-matching across files :( ).
Fixes: #1045
How to review this PR
Quality ✔️
Pre-requisites