Update AES Encryption to 256bits for script bootstrappers #1405
+50
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flin-8
changed the title
flin-8
commented
Dec 13, 2024
| @@ -17,9 +32,10 @@ public class AesEncryption | |||
|
|
|||
| readonly byte[] key; | |||
|
|
|||
| public AesEncryption(string password) | |||
| public AesEncryption(string password, int keySizeBits) | |||
There was a problem hiding this comment.
Making the key size configurable allows us to upgrade the 3 components (scripts, step package, variables file) separately.
flin-8
commented
Dec 13, 2024
|
|
||
| readonly int keySizeBits; | ||
|
|
||
| const int BlockSizeBits = 128; |
There was a problem hiding this comment.
Block size can remain at 128
flin-8
commented
Dec 13, 2024
| @@ -8,6 +8,21 @@ namespace Calamari.Common.Plumbing.Extensions | |||
| { | |||
| public class AesEncryption | |||
| { | |||
| //Key size used to encrypt variables for scripts (bash/powershell etc.) | |||
| //The variables are decrypted in the respective bootstrapper scripts | |||
| public static readonly int ScriptBootstrapKeySize = 256; | |||
There was a problem hiding this comment.
This PR only increases the key size for scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-98850]