Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWR Reverse Registrar ENS #95

Merged
merged 3 commits into from
Oct 11, 2023
Merged

OWR Reverse Registrar ENS #95

merged 3 commits into from
Oct 11, 2023

Conversation

samparsky
Copy link
Collaborator

No description provided.

@samparsky samparsky changed the title Reverse Registrar ENS OWR Reverse Registrar ENS Oct 4, 2023
@OisinKyne
Copy link
Contributor

We should document in some form of setup instructions that the _ensOwner needs to

  1. set the resolver for this ENS to the default one
  2. point the name the contract alleges to be at the contract, so it works properly, without that it won't get far.

@samparsky samparsky merged commit 2f0b5b4 into feat/audit Oct 11, 2023
1 check passed
@samparsky samparsky deleted the feat/ens-owr branch October 11, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OisinKyne OisinKyne OisinKyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samparsky @OisinKyne