Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support STM32U0 Family #336

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

xanthio
Copy link
Contributor

@xanthio xanthio commented Apr 8, 2024

Bring STM32U0 family support to project

@atsju atsju requested review from Hish15 and atsju April 8, 2024 11:55
Copy link
Collaborator

@atsju atsju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check the Flash sizes as I usually do but this looks high quality PR. Thank you.
@Hish15 I let you merge if it's OK for you

@xanthio
Copy link
Contributor Author

xanthio commented Apr 8, 2024

I did not check the Flash sizes as I usually do but this looks high quality PR. Thank you. @Hish15 I let you merge if it's OK for you

Actually, Flash size variants for this family is weird as we can find 16/32/64M of Flash but it depends the package:
U031C6
U031C8
U031F4
U031F6
U031F8
U031G6
U031G8
U031K4
U031K8
U031R6
U031R8

Do you think there is an interest in splitting this subfamilly ?

@atsju
Copy link
Collaborator

atsju commented Apr 8, 2024

I checked your code is actually correct.
example: U031C6 => U031 gives RAM size because is a specific subfamily and here all the subfamily has same RAM (cool, not always the case)
C => package => no interrest for us in this case. Sometimes it has an effect
6 => flash size. See file common.cmake

@xanthio
Copy link
Contributor Author

xanthio commented Apr 30, 2024

@Hish15 Is there an issue for not merging this PR ?

I'm starting a project with STM32U0 target and would really like to submodule this before.

@Hish15
Copy link
Collaborator

Hish15 commented Apr 30, 2024

Seems good to me, solve the conflict and we are good to go!

@xanthio
Copy link
Contributor Author

xanthio commented Apr 30, 2024

I didn't notice #337 breaked this
This should be OK now.

@Hish15 Hish15 merged commit aa4b996 into ObKo:master Apr 30, 2024
20 checks passed
@xanthio xanthio deleted the feature/STM32U0xx-support branch April 30, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants