translation for Demo Model Page #912
Conversation
|
@jgadsden what do you say about this? |
|
@jgadsden can i get your review on this ? |
| @@ -47,7 +47,12 @@ const ara = { | |||
| } | |||
| }, | |||
| demo: { | |||
| select: 'حدد نموذج تهديد تجريبي من القائمة أدناه' | |||
| select: 'حدد نموذج تهديد تجريبي من القائمة أدناه', | |||
| "New Threat Model": "نموذج تهديد جديد", | |||
There was a problem hiding this comment.
the names are not ideal, such as "New Threat Model", and should be renamed to something more in keeping with the rest of the attribute naming
There was a problem hiding this comment.
the names are not ideal, such as "New Threat Model", and should be renamed to something more in keeping with the rest of the attribute naming
Actually I gave such names because , these names i am getting in the front end page (SelectDemoModel.vue) as {{model.name}} from the backend
if you want i can change through the backend or you can suggest any other better solution ??
|
@jgadsden I did translation in each files with the help of google translate and cross checked them with other translation software.
however if you want , i will change only in the languages in which i am native? |
|
This PR is stale because it has been open 21 days with no activity. Remove stale label, or add a comment, otherwise it will be closed in 7 days. |
|
@itsdheerajdp could you consider this patch that will provide consistent attribute names and translate the strings only if we are fluent in the language (otherwise it could go wrong with Google translate): |
Sure I'll do it |
|
This PR is stale because it has been open 21 days with no activity. Remove stale label, or add a comment, otherwise it will be closed in 7 days. |
|
This PR was closed because it has been stalled for 28 days with no activity. |
Summary:
Now Our [Select Demo Model] Page is integrated with i18n and its content is available for other languages also as shown below.
Description for the changelog:
translation for Demo Model Page
Other info:
Fixes : #902