Ensure whitespace doesn't get trimmed when the text placeholders are replaced inside the paragraph. #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…replaced inside the paragraph.
rewtd
approved these changes
Apr 26, 2024
| @@ -1488,7 +1488,6 @@ def setUp(self) -> None: | |||
| self.replacement_values = [ | |||
| ("${VE_suit}", "Validation & Encoding"), | |||
| ("${VE_VE2_desc}", "You have invented a new attack against Data Validation and Encoding"), | |||
| ("${VE_VE2_misc'}", "Read more about this topic in OWASP's free Cheat Sheets"), | |||
There was a problem hiding this comment.
This is not really testing misc it’s testing how templating is suppose to work if the template label has the wrong case, contain apostroph or the template value is surrounded with whitespace. I removed it as this functionality is not used and make the code complicated and error prone.
| return v | ||
| elif el_text.strip().lower() == k2.lower(): | ||
| return v2 | ||
| elif convert_vars.making_template: |
There was a problem hiding this comment.
This code allowed templates to be created in the first place - it's probably no longer required and it exists in the git history if we ever need it again.
There was a problem hiding this comment.
Yes, I would not automaticly build templates. Keep in mind that we are talking about idml templates here, not yaml or docx
sydseter
added a commit
to sydseter/cornucopia
that referenced
this pull request
Jun 7, 2024
Ensure whitespace doesn't get trimmed when the text placeholders are replaced inside the paragraph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull-request:
I found some complicated code related to the replacing the text placeholders correctly even if the case was wrong. Very considerate, but it added a lot of complexity that didn't really take away the need for doing QA so I removed it. (only used for the idml files btw.)
owasp_cornucopia_ecommerce_cards_en_1.30_leaflet.pdf
owasp_cornucopia_ecommerce_cards_en_1.30_static.pdf