Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved Integrity and ProjectDoesNotExist Errors #3014

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Resolved Integrity and ProjectDoesNotExist Errors #3014

wants to merge 5 commits into from

Conversation

tsu-ki
Copy link
Contributor

@tsu-ki tsu-ki commented Nov 29, 2024 •
edited
Loading

Fixes issue: #3009

Screen.Recording.2024-11-29.at.2.09.56.PM.mov

@DonnieBLT
Copy link
Collaborator

if a project with the slug exists we want to throw an error not increment

DonnieBLT
DonnieBLT requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see change request

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Nov 30, 2024

if a project with the slug exists we want to throw an error not increment

oh, I'll make the required changes then, thank you

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Nov 30, 2024

@DonnieBLT is this solution correct?

Screen.Recording.2024-11-30.at.7.03.29.AM.mov

DonnieBLT
DonnieBLT previously approved these changes Nov 30, 2024
View reviewed changes
@DonnieBLT DonnieBLT enabled auto-merge (squash) November 30, 2024 01:38
auto-merge was automatically disabled November 30, 2024 01:49

Head branch was pushed to by a user without write access

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Nov 30, 2024

@DonnieBLT Can you please merge the PR? thank you so much

@tsu-ki tsu-ki mentioned this pull request Nov 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonnieBLT DonnieBLT DonnieBLT left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
requested changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsu-ki @DonnieBLT