Fix org name restriction, reference organization while starting timer. #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonnieBLT
reviewed
Nov 23, 2024
DonnieBLT
reviewed
Nov 23, 2024
DonnieBLT
requested changes
Nov 23, 2024
Thanks for the review |
|
@DonnieBLT I have done the changes you mentioned Here is the demo video: Recording.2024-11-24.125647.mp4 |
apoorvapendse
force-pushed
the
main
branch
4 times, most recently
from
e2529fd to
ad71fd2
Compare
|
can you squash the migrations please |
|
and maybe take out the prints |
apoorvapendse
force-pushed
the
main
branch
2 times, most recently
from
86f4d68 to
79ed3f6
Compare
|
Hey, @DonnieBLT Let me know if any other change is necessary 👍 |
apoorvapendse
force-pushed
the
main
branch
6 times, most recently
from
078a399 to
355ab1e
Compare
DonnieBLT
previously approved these changes
Nov 29, 2024
DonnieBLT
approved these changes
Nov 29, 2024
|
Thanks for the much needed assistance @DonnieBLT ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR in reference to issue 2851.
The bug inducing check of needing to match org name and domain name is removed with this PR.
Fixes #2851
Also the user can now optionally reference an org they want to allocate the current sizzle timelog towards with the help of the organization URL.
Right now, only the user who created the timer can see which organization they allocated their time logs.
