Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display and Manage Trademarks on company page #2624

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

HanilJain
Copy link
Contributor

Issue Solved

#2234
#2235

Images

Screenshot 2024-08-11 173914
Screenshot 2024-08-11 173935

Description

Trademark are displayed on the company page and can be managed on the company dashboard

website/models.py Show resolved Hide resolved
company/views.py Outdated Show resolved Hide resolved
company/views.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@DonnieBLT
Copy link
Collaborator

@HanilJain please see the comment on the requested changes.

@HanilJain
Copy link
Contributor Author

@HanilJain please see the comment on the requested changes.

@DonnieBLT Yes Sir I did work on the issue. But adding the model to Domain would be better than Company since we'll not be able to separate them Domain wise if added in company model. I would suggest to add either Domain or make new Trademark model connected with Company and Domain.

@DonnieBLT
Copy link
Collaborator

@HanilJain please see the comment on the requested changes.

@DonnieBLT Yes Sir I did work on the issue. But adding the model to Domain would be better than Company since we'll not be able to separate them Domain wise if added in company model. I would suggest to add either Domain or make new Trademark model connected with Company and Domain.

Ok a new trademark table linked to company makes sense.

@HanilJain
Copy link
Contributor Author

@HanilJain please see the comment on the requested changes.

@DonnieBLT Yes Sir I did work on the issue. But adding the model to Domain would be better than Company since we'll not be able to separate them Domain wise if added in company model. I would suggest to add either Domain or make new Trademark model connected with Company and Domain.

Ok a new trademark table linked to company makes sense.

Done. Please check

@DonnieBLT
Copy link
Collaborator

Can you check the test on this one?

@HanilJain
Copy link
Contributor Author

Can you check the test on this one?

@DonnieBLT Test made for this one

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the migrations into 1 file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

Successfully merging this pull request may close these issues.

3 participants