-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display and Manage Trademarks on company page #2624
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
@HanilJain please see the comment on the requested changes. |
@DonnieBLT Yes Sir I did work on the issue. But adding the model to Domain would be better than Company since we'll not be able to separate them Domain wise if added in company model. I would suggest to add either Domain or make new Trademark model connected with Company and Domain. |
Ok a new trademark table linked to company makes sense. |
Done. Please check |
Can you check the test on this one? |
@DonnieBLT Test made for this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please squash the migrations into 1 file
Issue Solved
#2234
#2235
Images
Description
Trademark are displayed on the company page and can be managed on the company dashboard