-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asynchronous Notification #2388
base: main
Are you sure you want to change the base?
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: website/views.py
Did you find this useful? React with a 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move the code into the existing Django app?
@DonnieBLT Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please send the link to the Python anywhere server so that I can test this on a live web server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to address:
suggested changes Co-authored-by: Arkadii Yakovets <[email protected]>
Thanks, please make sure those keys are revoked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-request review when you address the comments and resolve the conflicts
With free plan it causing limit CPU usage which increasing the time to deploy additionally memory is full so new dependencies can be installed. I'll try once today and report to you. |
Thanks for the update. Do you have a branch that I can look at and try to deploy it as well? |
@@ -67,6 +67,7 @@ | |||
# Application definition | |||
|
|||
INSTALLED_APPS = ( | |||
"daphne", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this
@@ -317,6 +327,7 @@ | |||
"0.0.0.0", | |||
"blt.owasp.org", | |||
"." + DOMAIN_NAME_PREVIOUS, | |||
"blt.onrender.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hanil, there are some change requests here.
@HanilJain how is this going? |
@HanilJain how is this going? |
Currently I am working on completing the proposal and soon we'll be deploying it. |
Could you provide an update on whether we've reduced the deploy size under 500MB and if there's a branch where the dependencies are being refactored out? |
Sir we'll setup a meet with swapnil sir to complete this. |
… async_project
Asynchronous Notification
Issue Addressed
#2213
#2214
#2215
#2216
#2217
#2218
#2221
How it works
Notification is created in model of notification_app
new_home frontend fetch api Notification.
websockets in header.html file handles the notification coming
memorychannellayer handles the cache and channel serving the notification to webscoket at port 6379
when user click on notification it gets deleted from database.