Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing /ghissue #21 #23

Merged
merged 10 commits into from
Jul 11, 2024
Merged

Testing /ghissue #21 #23

merged 10 commits into from
Jul 11, 2024

Conversation

Sarthak5598
Copy link
Member

#21

arkid15r
arkid15r reviewed Jul 9, 2024
View reviewed changes
src/sammich/plugins/create_issue.py Outdated Show resolved Hide resolved
src/sammich/plugins/create_issue.py Outdated Show resolved Hide resolved
@Sarthak5598
Copy link
Member Author

Thanks for the feedback @arkid15r , it really improved the code and made it much smaller!

@Sarthak5598 Sarthak5598 requested a review from arkid15r July 9, 2024 17:43
@Sarthak5598 Sarthak5598 mentioned this pull request Jul 9, 2024
Closed
arkid15r
arkid15r suggested changes Jul 11, 2024
View reviewed changes
src/sammich/plugins/create_issue.py Outdated Show resolved Hide resolved
src/sammich/plugins/create_issue.py Outdated Show resolved Hide resolved
src/sammich/plugins/create_issue.py Outdated Show resolved Hide resolved
src/settings.py Outdated Show resolved Hide resolved
src/sammich/plugins/create_issue.py Outdated Show resolved Hide resolved
@Sarthak5598 Sarthak5598 requested a review from arkid15r July 11, 2024 17:20
@Sarthak5598
Copy link
Member Author

Thanks for all the help @arkid15r !, I thinks its ready to merge now !

@arkid15r
Copy link
Contributor

Thanks for all the help @arkid15r !, I thinks its ready to merge now !

It seems tests are missing. Are you going to add them? Maybe in another PR?

@Sarthak5598
Copy link
Member Author

Sarthak5598 commented Jul 11, 2024 •
edited
Loading

I will tests for both this and reminder once both are done, In another PR

@arkid15r arkid15r merged commit dc6c7eb into OWASP-BLT:main Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

@DonnieBLT DonnieBLT Awaiting requested review from DonnieBLT DonnieBLT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sarthak5598 @arkid15r