Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the project slash command #14

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

JisanAR03
Copy link
Contributor

if your type wrong project name bot will provide a message preview

image

@arkid15r sir, please let me know , if there is any suggestion for me

@JisanAR03
Copy link
Contributor Author

@arkid15r sir, can you please review this PR

Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, @JisanAR03!

A few suggestions:

src/sammich/plugins/project.py Outdated Show resolved Hide resolved
src/sammich/plugins/project.py Outdated Show resolved Hide resolved
src/sammich/plugins/project.py Outdated Show resolved Hide resolved
src/sammich/plugins/project.py Outdated Show resolved Hide resolved
@JisanAR03 JisanAR03 requested a review from arkid15r June 25, 2024 07:04
Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you look into addressing .say() comments?

src/sammich/plugins/project.py Outdated Show resolved Hide resolved
@JisanAR03
Copy link
Contributor Author

JisanAR03 commented Jun 25, 2024

Could you look into addressing .say() comments?

yeah sir I have changed : "web_client.chat_postMessage" with "say()" at line-> 37 @arkid15r , can you please review now .

@JisanAR03 JisanAR03 requested a review from arkid15r June 25, 2024 21:07
Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you, Jisan!

@JisanAR03 JisanAR03 merged commit 5129607 into OWASP-BLT:main Jun 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants