Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison against string literal(s) #307

Open
wants to merge 3 commits into
base: DEV
Choose a base branch
from
Open

Fix comparison against string literal(s) #307

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fdbec2
Maybe fix str comparison bug
saarioka Sep 16, 2024
2fd3d71
str comparison fix
saarioka Sep 16, 2024
ebdec19
indent
saarioka Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Gui/GUIutils/guiUtils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,14 @@ def GenerateXMLConfig(firmwareList, testName, outputDir, **arg):
HyBridModule0.SetHyBridName(module.getModuleName())

moduleType = module.getModuleType()
RxPolarities = "1" if "CROC" and "Quad" in moduleType else "0" if "CROC" in moduleType else None
revPolarity = not ("CROC" and "1x2" in moduleType)

RxPolarities = None
if "CROC" in moduleType:
RxPolarities = "0"
if "CROC" in moduleType and "Quad" in moduleType:
RxPolarities = "1"

revPolarity = not ("CROC" in moduleType and "1x2" in moduleType)
FESettings_Dict = FESettings_DictB if "CROC" in moduleType else FESettings_DictA
globalSettings_Dict = globalSettings_DictB if "CROC" in moduleType else globalSettings_DictA
HWSettings_Dict = HWSettings_DictB if "CROC" in moduleType else HWSettings_DictA
Expand Down