Arduino script upload #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryansantos1174
requested changes
Dec 14, 2023
| logger.error("Error found:{}".format(err)) | ||
| # self.deviceMap[device] = device | ||
| compileResult=subprocess.run( | ||
| "$GUI_dir/bin/arduino-cli compile --fqbn arduino:avr:uno $GUI_dir/FirmwareImages/relay_box_firmware/", |
There was a problem hiding this comment.
Why is there the exact same code in 2 places?
There was a problem hiding this comment.
The "upload script" at Arduinowidget is for uploading the temperature monitoring script. And the one at QtApplication is for uploading the relay box script. The reason why I can't use "uploade script" in QtAplication for uploading temperature monitor script is that the button "Upload script" inside Arduinowidget can only connect the self function inside class ArduinoWidget.
|
|
||
| def listResources(self): | ||
| self.ResourcesManager = visa.ResourceManager("@py") | ||
| self.ResourcesList = [] |
There was a problem hiding this comment.
This function was removed? Do we not actually need it?
There was a problem hiding this comment.
listResources() is needed. It is used for getting Arduino communication port from site_settings.
updating arduino script branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge the script for uploading the Arduino ino file with GUI