Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get siblings #255

Open
wants to merge 10 commits into
base: update_CMSSW_13
Choose a base branch
from
Open

Update get siblings #255

wants to merge 10 commits into from

Conversation

carriganm95
Copy link
Contributor

@carriganm95 carriganm95 commented Sep 27, 2024

Updates to get siblings to first look for already processed events lists for secondary files

Can now run condor jobs to process event lists for a dataset

If you already have the dataset json file you can run

python3 submitCreateEventLists.py -j

or you can create it at time of running

python3 submitCreateEventLists.py -d

Files will be saved to a directory in /data/users/mcarrigan/condor/EventLists/, and getSiblings will look for these and only create event list if it is not found

@carriganm95 carriganm95 changed the base branch from master to update_CMSSW_13 September 27, 2024 21:24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file the same as the one in DBTools/scripts/createEventLists.py? If so, maybe this could be removed? I assume the other one to be the correct file, but correct me if I am wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes good catch there should only be the one in python

Copy link
Collaborator

@borzari borzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about a file. If you @carriganm95 and @mlj5j tested the changes and they worked fine, I can approve.

@carriganm95
Copy link
Contributor Author

I have rechecked this with EGamma_2022C, I also included new fiducial maps for muons/electrons in 2022F. If people still have issues with the skim edits I can separate the PRs

@borzari
Copy link
Collaborator

borzari commented Oct 16, 2024

I have rechecked this with EGamma_2022C, I also included new fiducial maps for muons/electrons in 2022F. If people still have issues with the skim edits I can separate the PRs

I saw the files again, and everything seems fine. Again, if you @carriganm95 and @mlj5j tested the siblings finding script and it worked fine, feel free to merge everything together

stop looking for resubmit failure reasons if one is already found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants