Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows testing #1032

Draft
wants to merge 26 commits into
base: dev
Choose a base branch
from
Draft

Update windows testing #1032

wants to merge 26 commits into from

Conversation

lsetiawan
Copy link
Member

Overview

This PR works on moving testing away from docker usage for compatibility across platforms, starting with windows.

@lsetiawan
Copy link
Member Author

Progress summary

This PR is still in progress as of 4/19/2023. Will be put on hold for now due to other pressing issues. I thought I was really close, but this will need some more thinking and experimentation in regards on how the test data should be distributed.

Ideas

  1. Replace docker build workflow with package test data workflow where the data is downloaded to google drive, zipped, and hosted somewhere
  2. The CI workflows would then download the zip file, extract, and use that as usual
  3. Update the tests to utilize built in python http server and moto package so that it can run cross platforms

TODOs

There are still a few todos based on the ideas above.

  • After playing around creating the test data package workflow, one thing occured to me as how I can get the google drive file id and pass that into each individual CI test run so it can get the correct file.
  • All of the test reference to minio_bucket need to change, as well as the http url should not have /data.

A partial solution that can be implemented quickly ASAP maybe a hybrid one, where the windows CI testing only run during push to dev or main and it can directly access the google drive avoiding the need to package the data and such. Then the other CI testing with linux can be done by still using docker as a way of getting the test data rather than the whole file hosting.

@lsetiawan lsetiawan self-assigned this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant