kiwi/schema: Fix allowed value type for ISO publisher and application ID

[Conan-Kudo]

According to the spec, this should be constrained to 128 characters but also allow whitespaces. We didn't allow spaces in application ID, but allowed too much for Publisher.

Now we set up both correctly.

Fixes #2617.

[Conan-Kudo]

@schaefi, @davidcassany: I'm pretty sure this necessitates a schema version bump, but I'm not sure how we handle implementing those.

[AdamWill]

note this still isn't strictly correct. Per the spec, several other characters are allowed - ! " % & ' ( ) * + , - . / : ; < = > ?. The more restrictive character set (just upper-case letters, numbers, and the underscore) is referred to in the spec as "d-characters", and used for e.g. the volume ID. The less restrictive set is referred to as "a-characters", and used for the application ID and publisher (and also the data preparer, the system identifier, and the "standard identifier", though that is always the same string anyway).

[Conan-Kudo]

Well, this isn't merged yet, so I can certainly add those in too. 😄

[schaefi]

@schaefi, @davidcassany: I'm pretty sure this necessitates a schema version bump, but I'm not sure how we handle implementing those.

Well so far we did not bump the schema version for this cases. You changed the strictness of a pattern applied to an attribute. Strictly speaking the schema did not change on any attribute or element or semantic structure. From that perspective no XSLT conversion is needed from old to new and thus we usually don't bump the schema version for such a change.

The version of kiwi itself will be bumped on a new tag that includes your change. Thus the increase of the pattern strictness can still be detected by a version compare of kiwi itself.

From my perspective this change can go in as soon as @AdamWill is fine with the final pattern

[Conan-Kudo]

The only character not added was the " character as I wasn't sure how to get that through with the file format (ie. I didn't know how to escape it properly).

[Conan-Kudo]

And now all the tests fail anyway because the regex is somehow invalid 😩

[Conan-Kudo]

Now everything should be good now! 😄

[schaefi]

Looks good to me, thanks much 👍