-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing some errors in the release workflow #47
Conversation
As we can choose which branch manually from options
I think it should work now without errors @ltorres6 |
Thanks Mohamed. Can you add a configuration option to select which repository we want to publish to? I'd like to be able to test by publishing to https://test.pypi.org/. This should be a similar configuration setup as you have for the "major/minor/patch" config. Additionally, please set up the workflow to automatically use the user's information (who is running the workflow) for the git commands. |
… sematic-version
I think it should work now, the error I get is related to trusted publisher configuration @ltorres6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I fixed the error you were having on testpypi. https://test.pypi.org/project/osipi/4.0.0/
Need to add release notes and releases on github.
Sorry, I noticed we aren't actually creating releases on github, which we should do in the pipeline. Please add this. Additionally, we should include all notes from PR merges in the release notes. This will involve looking up the notes between the previous release and the current one and including it in the release notes body. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
No description provided.