Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some errors in the release workflow #47

Merged
merged 33 commits into from
Sep 9, 2024
Merged

Conversation

MohamedNasser8
Copy link
Collaborator

No description provided.

As we can choose which branch manually from options
@MohamedNasser8
Copy link
Collaborator Author

I think it should work now without errors @ltorres6

@ltorres6
Copy link
Collaborator

Thanks Mohamed. Can you add a configuration option to select which repository we want to publish to? I'd like to be able to test by publishing to https://test.pypi.org/. This should be a similar configuration setup as you have for the "major/minor/patch" config.

Additionally, please set up the workflow to automatically use the user's information (who is running the workflow) for the git commands.

@MohamedNasser8
Copy link
Collaborator Author

I think it should work now, the error I get is related to trusted publisher configuration @ltorres6

@ltorres6 ltorres6 self-requested a review September 4, 2024 02:09
ltorres6
ltorres6 previously approved these changes Sep 4, 2024
Copy link
Collaborator

@ltorres6 ltorres6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I fixed the error you were having on testpypi. https://test.pypi.org/project/osipi/4.0.0/

@ltorres6 ltorres6 self-requested a review September 4, 2024 02:40
@ltorres6 ltorres6 dismissed their stale review September 4, 2024 02:41

Need to add release notes and releases on github.

@ltorres6
Copy link
Collaborator

ltorres6 commented Sep 4, 2024

Sorry, I noticed we aren't actually creating releases on github, which we should do in the pipeline. Please add this. Additionally, we should include all notes from PR merges in the release notes. This will involve looking up the notes between the previous release and the current one and including it in the release notes body.

Copy link
Collaborator

@ltorres6 ltorres6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ltorres6 ltorres6 merged commit e78d9e2 into main Sep 9, 2024
5 checks passed
@ltorres6 ltorres6 deleted the sematic-version branch September 9, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants