Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created the dockerise version of the TF2.4_IVIM-MRI_CodeCollection #66

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

Unique-Usman
Copy link
Contributor

###Created the dockerise version of the TF2.4_IVIM-MRI_CodeCollection
Fixes #64

@etpeterson Kindly check the Dockerfile for any changes and also the the .dockerignore for files you think we can ignore.

When I build this, the size of the whole image was about 6.3gb which I think might be too big.

As of now it works perfectly.

Also, which repository are we pushing the image to ?

Also, I remove the loggin in the requirement.txt as it is a builtin python library and it is causing issue.

Thank you.

Copy link
Contributor

@etpeterson etpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I haven't tried it yet however, but it seems like it should build. I wouldn't be too worried about the build size. You could explore the alpine based ones, but that's probably not worth it.

requirements.txt Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
.dockerignore Outdated Show resolved Hide resolved
…ed directory for the Dockerfile and also added a README file to explain the build and run process
@Unique-Usman
Copy link
Contributor Author

I tried out alpine image, but, it does not work as it does not have support for installing pytorch.

@etpeterson etpeterson merged commit 28b516b into OSIPI:main Jun 7, 2024
12 checks passed
@etpeterson
Copy link
Contributor

Looks good. I actually haven't been able to test it but it's a new feature and low impact on existing things, so I think it's safe to merge. I'll try to check in the next few days though.

@Unique-Usman
Copy link
Contributor Author

Unique-Usman commented Jun 7, 2024

Thanks @etpeterson, let's move to the next goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Docker container
2 participants