Added LDAP Apache modules as default in the Apache configuration #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The default deployment for the Puppet module should mirror default setups with OnDemand, which is OIDC with Dex, or none. Forcing people to have LDAP related things added when they don't use LDAP is far from ideal. In Puppet these kind of customizations should go into your site's control repo into a profile class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bill from the IQSS team was reviewing our puppet configuration for OnDemand and realized that we were including the LDAP apache modules within our configuration.
Should the LDAP modules be part of the default modules added by the Apache config in OnDemand?