Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3944 add file browser to projects#show #3981

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

euler-room
Copy link
Contributor

@euler-room euler-room commented Nov 27, 2024

This PR is incomplete:

  • - needs tests
  • - sorting is functional but buggy
  • - code could be better organized

@euler-room euler-room marked this pull request as ready for review December 10, 2024 17:43
@johrstrom
Copy link
Contributor

This is so big it's going to take me a bit to go through.

At a glance though, I did not expect so many updates to the project models. It seemed to me like this is would initiate on the client side.

I mean I'd envisioned it as on initial load, there's some empty div, then there's client side javascript to make a query to the files controller that then returns the partial. So that the project controller doesn't even really know/care about any of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants