refactor completed_view method (#3277)

OSC · Jan 5, 2024 · a23c2f7 · a23c2f7
1 parent 5170447
commit a23c2f7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/apps/dashboard/app/helpers/batch_connect/sessions_helper.rb b/apps/dashboard/app/helpers/batch_connect/sessions_helper.rb
@@ -68,18 +68,9 @@ def custom_info_view(session)
       end
     end
   end
-
-  def completed_view(session)
-    concat tag.hr
-    content_tag(:div) do
-      concat session.render_completed_view
 
-      if session.render_completed_view_error_message
-        content_tag(:div, class: "alert alert-danger", role: "alert") do
-          concat tag.p session.render_completed_view_error_message
-        end
-      end
-    end
+  def completed_view(session)
+    render(partial: 'batch_connect/sessions/card/completed_view', locals: { session: session })
   end
 
   def created(session)

diff --git a/apps/dashboard/app/views/batch_connect/sessions/card/_completed_view.html.erb b/apps/dashboard/app/views/batch_connect/sessions/card/_completed_view.html.erb
@@ -0,0 +1,9 @@
+<hr>
+<div>
+  <%= session.render_completed_view %>
+  <% if session.render_completed_view_error_message %>
+    <div class="alert alert-danger" role="alert">
+      <p><%= session.render_completed_view_error_message %></p>
+    </div>
+  <% end %>
+</div>