Avoiding TypeError or wrong CPR code of the child

OS2web · May 25, 2023 · e5c06ce · e5c06ce
1 parent 9cac753
commit e5c06ce
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/src/Plugin/os2web/DataLookup/ServiceplatformenCPRExtended.php b/src/Plugin/os2web/DataLookup/ServiceplatformenCPRExtended.php
@@ -122,13 +122,20 @@ public function lookup($cpr, $allowCprTestModeReplace = TRUE) {
           $relationship->barn = [$relationship->barn];
         }
 
-        foreach ($relationship->barn as $child) {
-          $childCprResult = $this->lookup($child->personnummer, FALSE);
-
-          $children[] = [
-            'cpr' => $childCprResult->getCpr(),
-            'name' => $childCprResult->getName(),
+        foreach ($relationship->barn as $relationshipChild) {
+          // Sometimes CPR lookup can return no results, creating child without
+          // name.
+          $child = [
+            'cpr' => $relationshipChild->personnummer,
+            'name' => '',
           ];
+
+          $childCprResult = $this->lookup($relationshipChild->personnummer, FALSE);
+          if ($childCprResult->isSuccessful()) {
+            $child['name'] = $childCprResult->getName();
+          }
+
+          $children[] = $child;
         }
       }
       $cprResult->setChildren($children);