Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix i18n ids and translations values #1223

Merged
merged 11 commits into from
Jun 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/app/account/password/password.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ <h1 class="mt-3" *ngIf="username">{{ passwordForUsernameString }}</h1>
class="form-control"
id="currentPassword"
name="currentPassword"
i18n-placeholder="@@global.form.currentpassword.placeholder.string'"
i18n-placeholder="@@global.form.currentpassword.placeholder.string"
placeholder="Current password"
formControlName="currentPassword"
/>
Expand Down
17 changes: 10 additions & 7 deletions ui/src/app/account/settings/settings.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,13 @@ <h1 class="mt-3" i18n="@@settings.security.heading.string">Security</h1>
<div class="col-md-8">
<ul>
<li i18n="@@settings.security.mfaQrCodeSteps.one.string">
<strong>Install a two-factor authentication app</strong><br />A 2FA app is required to create the six-digit code you need
to access your account each time you sign in. Most apps are for mobile devices; some are also available
as desktop or web-based apps. Download and install your preferred 2FA app, such as
<strong>Install a two-factor authentication app</strong><br />A 2FA app is required to create the
six-digit code you need to access your account each time you sign in. Most apps are for mobile devices;
some are also available as desktop or web-based apps. Download and install your preferred 2FA app, such
as
<a href="https://play.google.com/store/apps/details?id=com.google.android.apps.authenticator2"
>Google Authenticator</a
>, <a href="https://freeotp.github.io/">FreeOTP</a>, or <a href="https://authy.com/">Authy</a>.
>, <a href="https://freeotp.github.io/">FreeOTP</a> or <a href="https://authy.com/">Authy</a>.
</li>
<li i18n="@@settings.security.mfaQrCodeSteps.two.string">
<strong>Scan this QR code with your device</strong><br />Open your 2FA app and scan the image below.
Expand All @@ -193,7 +194,8 @@ <h1 class="mt-3" i18n="@@settings.security.heading.string">Security</h1>
<div class="col-md-8">
<ul>
<li>
<span i18n="@@settings.security.mfaCannotScan.one.string"><strong>Can't scan the QR code?</strong></span><br /><a
<span i18n="@@settings.security.mfaCannotScan.one.string"><strong>Can't scan the QR code?</strong></span
><br /><a
href="JavaScript:void(0);"
(click)="toggleMfaTextCode()"
i18n="@@settings.security.mfaCannotScan.two.string"
Expand All @@ -203,8 +205,9 @@ <h1 class="mt-3" i18n="@@settings.security.heading.string">Security</h1>
>
</li>
<li i18n="@@settings.security.mfaTextCodeSteps.one.string">
<strong>Enter the six-digit code from the app</strong><br />After scanning the QR code or entering in the text code, your
2FA app will display a six-digit code. Enter this code in the box below and click Save.
<strong>Enter the six-digit code from the app</strong><br />After scanning the QR code or entering in
the text code, your 2FA app will display a six-digit code. Enter this code in the box below and click
Save.
</li>
</ul>
</div>
Expand Down
6 changes: 2 additions & 4 deletions ui/src/app/affiliation/affiliation-detail.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ <h1 class="mt-5" i18n="@@gatewayApp.assertionServiceAssertion.detail.title.strin
</dd>
<dt class="col-md-3" i18n="@@gatewayApp.assertionServiceAssertion.status.string">Status</dt>
<dd class="col-md-9">
{{ affiliation.prettyStatus }}
{{ affiliation.prettyStatus || '' | localize }}
</dd>
<dt
*ngIf="affiliation.permissionLink"
Expand Down Expand Up @@ -50,9 +50,7 @@ <h1 class="mt-5" i18n="@@gatewayApp.assertionServiceAssertion.detail.title.strin
Affiliation Section
</dt>
<dd class="col-md-9">
<span i18n="@@{{'gatewayApp.AffiliationSection.' + affiliation.affiliationSection + '.string'}}">{{
affiliation.affiliationSection
}}</span>
<span>{{ affiliation.affiliationSection! | localize }}</span>
</dd>
<dt class="col-md-3" i18n="@@gatewayApp.assertionServiceAssertion.detail.org.string">Organization</dt>
<dd class="col-md-9">
Expand Down
4 changes: 1 addition & 3 deletions ui/src/app/affiliation/affiliations.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,7 @@ <h1 id="page-heading" class="mt-3" i18n="@@gatewayApp.assertionServiceAssertion.
>
</td>
<td>
<span i18n="@@{{'gatewayApp.AffiliationSection.' + affiliation.affiliationSection + '.string'}}">{{
affiliation.affiliationSection
}}</span
<span>{{ affiliation.affiliationSection! | localize }}</span
><br />
{{ affiliation.orgName }}: <span *ngIf="affiliation.orgCity">{{ affiliation.orgCity }}</span
><span *ngIf="affiliation.orgRegion">, {{ affiliation.orgRegion }}</span
Expand Down
4 changes: 3 additions & 1 deletion ui/src/app/error/error-alert.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<div *ngFor="let alert of alerts">
<ngb-alert *ngIf="alert && alert.type && alert.msg" [type]="alert.type" [dismissible]="false">
<div class="d-flex">
<p i18n="@@error.subtitle" class="font-size-16 font-weight-bold mr-auto mb-2">Sorry, an error has occurred</p>
<p i18n="@@error.subtitle.string" class="font-size-16 font-weight-bold mr-auto mb-2">
Sorry, an error has occurred
</p>
<a (click)="close(alert)" (keyup.esc)="closeOldestAlert()" (keyup.enter)="closeOldestAlert()" tabindex="0">
<svg width="12" height="12" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<path
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/home/home.component.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="d-flex flex-column h-100">
<div class="alert alert-success mt-3" data-cy="signedInMessage">{{ loggedInMessage }}</div>
<div class="alert alert-success mt-3" data-cy="signedInMessage" [innerHTML]="loggedInMessage"></div>
<div class="h-100 pb-3">
<router-outlet></router-outlet>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/member/member-import-dialog.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ <h4 class="modal-title" i18n="@@gatewayApp.msUserServiceMSMember.import.title.st
<div class="form-group">
<label
class="form-control-label sr-only"
i18n="@@gatewayApp.msUserServiceMSMember.import.filePath"
i18n="@@gatewayApp.msUserServiceMSMember.import.filePath.string"
for="field_filePath.string"
>File Path</label
>
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/member/member-import-dialog.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class MemberImportDialogComponent {
})
} else {
alert(
$localize`:gatewayApp.msUserServiceMSUser.import.emptyFile.string:There is no file to upload. Please select one.`
$localize`:@@gatewayApp.msUserServiceMSUser.import.emptyFile.string:There is no file to upload. Please select one.`
)
}
}
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/user/user-import-dialog.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class UserImportDialogComponent {
})
} else {
alert(
$localize`:gatewayApp.msUserServiceMSUser.import.emptyFile.string:There is no file to upload. Please select one.`
$localize`:@@gatewayApp.msUserServiceMSUser.import.emptyFile.string:There is no file to upload. Please select one.`
)
}
}
Expand Down
Loading
Loading